-
Notifications
You must be signed in to change notification settings - Fork 201
TrueHD: Improve support #2379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
TrueHD: Improve support #2379
Conversation
1e263fa to
beba6a5
Compare
|
Tried to improve the |
e48e6ae to
cd6c6b7
Compare
|
MediaInfoLib/Source/MediaInfo/Audio/File_Ac3.cpp Lines 4256 to 4261 in d93cc8c
Does not seem to match specs:
|
9b36853 to
ad3e853
Compare
605dc36 to
7cde1cb
Compare
|
@JeromeMartinez There should be nothing else now. Almost complete parsing of TrueHD and OAMD now. Also CRC and parity computations for TrueHD. At the moment, only two of the CRC/parity are used, the others are only computed during trace. All CRC/parity results are only shown in trace. I did not do anything regarding the items mentioned in the above two posts. |
|
Not related to this PR but noticed that for raw TrueHD stream, even with full parse, there is no duration and bitrate in output. |
It was not implemented for full parse, but should be easy, I'll give it a look. |
c5ed93d to
f20490e
Compare
b505215 to
267ac10
Compare
|
Malformed EMDF E-AC3 samples that can crash Dolby's official decoders (CVE-2025-54957) may be useful for testing and can be found here: |
- Remove redundant codes - Remove unused variables - Fix padding handling
More parsing and improved trace output for Dolby TrueHD. I put some of the new codes under a TrueHD/FBA check since I do not have MLP/FBB info or samples to know if it is the same.