Skip to content

JXL: Parse Exif and XMP #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cjee21 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JXL: Parse Exif and XMP #2463

cjee21 wants to merge 2 commits into from

Conversation

@cjee21
Copy link
Contributor

@cjee21 cjee21 commented Oct 30, 2025

No description provided.

JeromeMartinez
JeromeMartinez reviewed Oct 30, 2025
View reviewed changes
Source/MediaInfo/Tag/File_Exif.cpp Outdated
if (FromHeif) {
int32u Size;
Get_B4 (Size, "Exif header length");
Get_B4 (Size, "Tiff header offset");
Copy link
Member

@JeromeMartinez JeromeMartinez Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not seem coherent.

Copy link
Contributor Author

@cjee21 cjee21 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found ISO/IEC 23008-12...

Screenshot 2025-10-30 at 21-54-40 ISO_IEC 23008-12 2017 - iso-iec-23008-122017-information-technology-high-efficiency-coding-and-media-delivery-in-heterogeneous-environments-part-12-image-file-format-part-12-image-file-format

Copy link
Contributor Author

@cjee21 cjee21 Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That part was previously added in 8a2c57c then was modified by me to parse more files that have zero offset. Looks like that identifier is not part of specs? Maybe some other files may have offset other than 0 or 6?

Copy link
Member

@JeromeMartinez JeromeMartinez Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have a source, let's go with that.
The specs seems to tolerate something else that Exif\0\0, no strong preference but I would keep the check on the value until we find any other value. too strict?

@cjee21 cjee21 force-pushed the jxl branch 2 times, most recently from 666aa16 to 66e0f78 Compare October 30, 2025 14:13
@cjee21
Copy link
Contributor Author

cjee21 commented Oct 30, 2025 •
edited
Loading 

Writing application                      : Ricoh Adobe Photoshop Camera Raw 16.0
Writing operating system                 : Apple macOS
Writing hardware                         : Ricoh Pentax 645Z

Application name has Ricoh wrongly added.

0000A6  Manufacturer of image input equipment - RICOH IMAGING COMPANY, LTD. (28 bytes)
0000A6   Data:                                 RICOH IMAGING COMPANY, LTD.
0000C2  Model of image input equipment - PENTAX 645Z (12 bytes)
0000C2   Data:                                 PENTAX 645Z
0000CE  Software used - Adobe Photoshop Camera Raw 16.0 (Macintosh) (44 bytes)
0000CE   Data:                                 Adobe Photoshop Camera Raw 16.0 (Macintosh)

@JeromeMartinez
Copy link
Member

JeromeMartinez commented Oct 30, 2025

Application name has Ricoh wrongly added.

Argh, everyone does as it wants, not easy to have a good rule...
sample file? (I could forge one but better if I have a real one)

@cjee21
Copy link
Contributor Author

cjee21 commented Oct 30, 2025

sample file?

I simply picked one from the link posted in JPEG XL issue -> https://people.csail.mit.edu/ericchan/hdr/jxl_images/20140606_102418_IMGP0297.jxl

@cjee21
Copy link
Contributor Author

cjee21 commented Oct 30, 2025

The XML is brotli compressed in this one.

@cjee21 cjee21 force-pushed the jxl branch 4 times, most recently from 1b43ba9 to 0af26ec Compare October 30, 2025 18:56
@cjee21
Copy link
Contributor Author

cjee21 commented Oct 30, 2025

@JeromeMartinez I am not sure what you plan to do with the Brotli compressed data in JXL. I just did a quick implementation for MSVC only just for testing to see what's in there.

@JeromeMartinez
Copy link
Member

JeromeMartinez commented Oct 30, 2025

I am not sure what you plan to do with the Brotli compressed data in JXL

I am very interested, but I would like something similar to zlib, with using system libs on Linux and (patched, with specific build projects if needed) on Win & Mac.
I added https://github.com/MediaArea/brotli , in case you are motivated enough (please :) ) for implementing something similar to zlib.

@cjee21 cjee21 force-pushed the jxl branch 6 times, most recently from c3cf290 to feb2fcb Compare October 31, 2025 10:35
@cjee21
Copy link
Contributor Author

cjee21 commented Oct 31, 2025

@JeromeMartinez I think I got MSVC project done. Cannot figure out CMake and no idea about MacOS or Linux makefiles.

@JeromeMartinez
Copy link
Member

JeromeMartinez commented Oct 31, 2025

@cjee21 thank you for your work. We'll try on our side to manage the other makefiles.
(but no ETA :( )

@cjee21 cjee21 force-pushed the jxl branch 4 times, most recently from 443950a to bacc8d5 Compare October 31, 2025 12:40
@cjee21
Copy link
Contributor Author

cjee21 commented Oct 31, 2025

Not sure if I have done it the right way but CMake also works now.

@JeromeMartinez
Copy link
Member

JeromeMartinez commented Oct 31, 2025

Not sure if I have done it the right way but CMake also works now.

thank you!

@cjee21 cjee21 force-pushed the jxl branch 6 times, most recently from fb7d678 to fa34d28 Compare November 30, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeromeMartinez JeromeMartinez JeromeMartinez left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cjee21 @JeromeMartinez