Skip to content

Conversation

@cjee21
Copy link
Contributor

@cjee21 cjee21 commented Oct 31, 2025

Follow-up of #2201
Resolves MediaArea/MediaInfo#1183

@cjee21
Copy link
Contributor Author

cjee21 commented Oct 31, 2025

@JeromeMartinez I left the previous codes there if you want to add an option.

@cjee21
Copy link
Contributor Author

cjee21 commented Oct 31, 2025

There might be edge cases when there is a character with more bytes than a wchar.

@JeromeMartinez
Copy link
Member

Do I interpret well that you switch from full width to 2 half width spaces?

the impact is what I saw when manually editing, for example with a copy paste on GitHub:

Before:

ID                                       : 1
形式                                       : HEVC
形式/情報                                    : High Efficiency Video Coding
形式のプロファイル                                : Main 10@L5.1@Main
HDR 形式                                   : Dolby Vision, Version 1.0, Profile 5, dvhe.05.09, BL+RPU, no metadata compression
コーデック ID                                 : dvh1

After:

ID                                       : 1
形式                                     : HEVC
形式/情報                                : High Efficiency Video Coding
形式のプロファイル                       : Main 10@L5.1@Main
HDR 形式                                 : Dolby Vision, Version 1.0, Profile 5, dvhe.05.09, BL+RPU, no metadata compression
コーデック ID                            : dvh1

It was aligned, it is no more with this patch.
So I think I prefer to keep the previous behavior by default (but I reduce the count of characters for avoiding huge width) + this patch as an option for who knows what is done (and ready to lose the alignment during a copy/paste).

I understand that it is due to choice of a font in the web browser, but as it is the default font, it is what most users see.

@cjee21
Copy link
Contributor Author

cjee21 commented Nov 3, 2025

Do I interpret well

This patch is for optimal display in terminals (default/any font) and also in GUI (with correct monospace font for selected language). Result is as seen at MediaArea/MediaInfo#1183 (comment)

prefer to keep the previous behavior by default ... patch as an option

Up to you and the others. It does not matter much to me as I only use English and only have filenames/tags in CJK languages which isn't affected since those are on the right side of the colons.

What should the option be called and I am not sure how to add an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MediaInfo abnormal display in English for Japanese tranlsation

2 participants