fix: Match group keys by scancode as well as keysym (#360)#373
Open
fix: Match group keys by scancode as well as keysym (#360)#373
Conversation
On ARM Linux (Raspberry Pi 5) SDL2 uses the Wayland backend with libxkbcommon, which can transform keysym.sym for modifier+key combinations so that Ctrl+1 no longer matches SDLK_1. Scancodes represent the physical key position and are unaffected by modifier state or backend differences. Add a scancode fallback: convert the configured SDL_Keycode to its corresponding SDL_Scancode via SDL_GetScancodeFromKey() and accept a match on either sym or scancode, so Ctrl+Num group keys work on all platforms. Fixes #360 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andy5995
force-pushed
the
fix/group-key-arm
branch
from
1c1e6d8 to
d6b4ec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ARM Linux (Raspberry Pi 5) SDL2 uses the Wayland backend with libxkbcommon, which can transform keysym.sym for modifier+key combinations so that Ctrl+1 no longer matches SDLK_1. Scancodes represent the physical key position and are unaffected by modifier state or backend differences.
Add a scancode fallback: convert the configured SDL_Keycode to its corresponding SDL_Scancode via SDL_GetScancodeFromKey() and accept a match on either sym or scancode, so Ctrl+Num group keys work on all platforms.
Fixes #360