fix: Resolve compile-time warnings in first-party code#376
Open
fix: Resolve compile-time warnings in first-party code#376
Conversation
- Fix logic bug in unit_type.cpp: dangling string expression was a no-op (missing `desc +=` prefix); result was silently discarded - Fix -Wterminate in renderer.cpp: throwing from a destructor calls terminate() in C++11; log and swallow instead - Fix -Wformat-overflow in main.cpp (30 sites): NULL passed as %s argument to printf causes UB; replaced with "" - Fix -Wreorder in network_types.cpp and menu_state_root.cpp: member initializer order didn't match declaration order - Fix -Wswitch in 11 switch statements across commander.cpp, game.cpp, core_data.cpp, gui.cpp, unit_updater.cpp, client_interface.cpp, server_interface.cpp, network_message.cpp, menu_state_mods.cpp, and glest_map_editor (main.cpp, program.cpp): add `default: break;` for intentionally unhandled enum values Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
desc +=prefix); result was silently discardeddefault: break;for intentionally unhandled enum values