fix: address three threading issues that could cause intermittent OOS#384
Open
fix: address three threading issues that could cause intermittent OOS#384
Conversation
1. Replace piecemeal pendingCommands access with atomic takePendingCommands() snapshot, guarded by pendingCommandsMutex (shared with the client's networkCommandListThreadAccessor), eliminating a TOCTOU race between the network receive thread and the game-loop thread. 2. Replace static-local alreadyInLagCheck with a ServerInterface member variable inLagCheck, so the reentrancy guard is per-instance and is properly reset on construction. 3. Wrap the requestedCommands drain loop in updateKeyframe() with serverSynchAccessor, which already guards requestCommand() writes. Overflow count is captured inside the lock and the warning broadcast is sent after releasing it to avoid potential deadlock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andy5995
force-pushed
the
investigate/threading-oos
branch
from
db831f3 to
d43873f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace piecemeal pendingCommands access with atomic takePendingCommands() snapshot, guarded by pendingCommandsMutex (shared with the client's networkCommandListThreadAccessor), eliminating a TOCTOU race between the network receive thread and the game-loop thread.
Replace static-local alreadyInLagCheck with a ServerInterface member variable inLagCheck, so the reentrancy guard is per-instance and is properly reset on construction.
Wrap the requestedCommands drain loop in updateKeyframe() with serverSynchAccessor, which already guards requestCommand() writes. Overflow count is captured inside the lock and the warning broadcast is sent after releasing it to avoid potential deadlock.