Skip to content

fix: handle reserved words in table names#232

Draft
pnadolny13 wants to merge 12 commits intomainfrom
reserved_table_name
Draft

fix: handle reserved words in table names#232
pnadolny13 wants to merge 12 commits intomainfrom
reserved_table_name

Conversation

@pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jul 26, 2024

Closes #230

Adds failing test for:

  • creating a table that includes a reserved word (ORDER) and trying to insert into it
  • altering an existing table that has a reserved word as its name

@pnadolny13 pnadolny13 changed the title fix: add test to alter a table using a reserved word fix: handle reserved words in table names Jul 26, 2024
@pnadolny13
Copy link
Contributor Author

pnadolny13 commented Aug 12, 2024

@edgarrmondragon see my recent changes. They solve the bug but not in a very elegant way, I was just hacking in fixes as I was running the tests so its not very well thought out, I'll probably refactor to clean it up.

The gist is that instead of using conform_name to add quotes consistently in one place, since it had negative side effects, I send the full table name through the quote function for any case that we're building SQL string manually. The tests pass but I do worry that theres SDK string SQL building flows that I'm missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

bug: SQL compilation error...unexpected '.' when table name is ORDER

1 participant