Skip to content

Conversation

@fixterjake
Copy link
Contributor

No description provided.

@fixterjake fixterjake requested a review from Copilot June 17, 2025 15:13
@fixterjake fixterjake self-assigned this Jun 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR, titled "lots of updates", refactors and updates role validations and permission constants across many controllers and services, while also adding new endpoints and validators. Key changes include:

  • Addition of a new validator registration for ExamRequestPayload.
  • Updating authorization attributes to use new role constants.
  • Introduction of new endpoints such as AddComment, GetRoles, and new ExamRequests-related operations.

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Memphis.API/Program.cs Added registration for ExamRequestPayload validator.
Memphis.API/Extensions/HttpContextExtensions.cs Updated role constant usage in staff-related helper methods.
Memphis.API/Controllers/UsersController.cs Renamed validator fields and added new comment and role endpoints.
Memphis.API/Controllers/TransferRequestsController.cs Fixed Authorize attribute formatting.
Memphis.API/Controllers/TrainingSchedulesController.cs Updated role checks for training schedule creation.
Memphis.API/Controllers/TrainingMilestonesController.cs Updated role constants for training milestones operations.
Memphis.API/Controllers/StaffingRequestsController.cs Added new endpoint to retrieve staffing requests.
Memphis.API/Controllers/SessionsController.cs Changed authorization for session retrieval to FullStaff.
Memphis.API/Controllers/ProfileController.cs Added new profile-related endpoint for updating Discord ID.
Memphis.API/Controllers/OtsController.cs Updated role constants for Ots endpoints.
Memphis.API/Controllers/NewsController.cs Updated role validations for news endpoints.
Memphis.API/Controllers/FilesController.cs Updated role checks and minor refactor in variable declaration.
Memphis.API/Controllers/FeedbackController.cs Updated role validations for feedback endpoints.
Memphis.API/Controllers/ExamRequestsController.cs Introduced new exam request endpoints with role validations.
Memphis.API/Controllers/EventsController.cs Updated role constants for event endpoints.
Memphis.API/Controllers/EventRegistrationController.cs Updated role constants for event registration endpoints.
Memphis.API/Controllers/EventPositionsController.cs Updated role checks and validation changes for event positions.
Memphis.API/Controllers/EmailLogsController.cs Updated role validations for retrieving email logs.
Memphis.API/Controllers/CommentsController.cs Updated role validations for comment endpoints and removed confidential flag.
Memphis.API/Controllers/AirportsController.cs Updated role validations and adjusted variable declaration style.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@fixterjake fixterjake merged commit 826dfc9 into main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants