exposes cities directly from Country#22
Open
chriys wants to merge 3 commits intoMenaraSolutions:masterfrom
Open
exposes cities directly from Country#22chriys wants to merge 3 commits intoMenaraSolutions:masterfrom
chriys wants to merge 3 commits intoMenaraSolutions:masterfrom
Conversation
|
@dusterio hi Denis, could this PR be merged into main package? |
Member
|
@janisblaus good idea, but would be nice to return a collection for consistency purposes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to get all cities within a country tested with small country like Maldives. although not included in tests it was also tested with Luxembourg.
For now it only return an array. A collection is coming soon.