Open
Conversation
- Updated app.overlay to configure external flash settings for font storage. - Added new Kconfig options for runtime font loading and XIP usage. - Introduced shell commands for font storage management, including info and read operations. - Implemented font loading from external flash with support for XIP and RAM. - Modified display control to support GBK text rendering and improved command handling. Files modified: 20, New files: 8
… commands - Updated mos_font_storage.c and mos_xbf_font.c to support an additional font storage partition (PM_FONT_STORAGE2). - Modified display_config.c to streamline font loading for CJK text, removing the XBF font preference due to initialization issues. - Adjusted mos_lvgl_display.c to set the display brightness to 100% on initialization. - Enhanced shell_display_control.c with new commands for displaying binfont test text and CJK text from UTF-8 hex strings. - Introduced cmd_font_storage_glyph in shell_font_storage.c to read glyph data by Unicode value, improving font management capabilities.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16694033 | Triggered | JSON Web Token | b87c75b | .github/workflows/china-deploy-static-websites-dev.yaml | View secret |
| 22988493 | Triggered | Generic High Entropy Secret | b87c75b | .github/workflows/china-deploy-static-websites-dev.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Comment on lines
+2
to
+9
| * @Author : Cole | ||
| * @Date : 2026-01-28 14:44:46 | ||
| * @LastEditTime : 2026-02-07 15:00:36 | ||
| * @FilePath : mos_fuel_gauge.c | ||
| * @Description : | ||
| * | ||
| * Copyright (c) MentraOS Contributors 2026 | ||
| * SPDX-License-Identifier: Apache-2.0 |
yagarwal1307
approved these changes
Feb 10, 2026
- Removed the FONT_STORAGE_PREFER_BINFONT option from Kconfig and adjusted related configurations in prj.conf. - Updated pm_static.yml to reflect new partition sizes and addresses for font storage. - Deleted unused bin_to_hex_font_storage.py script and related XBF font files to streamline the project. - Enhanced display configuration to improve font loading and error handling for CJK text rendering. Files modified: 8, Deleted files: 3
- Renamed CJK font references to GBK in Kconfig and display configuration files to reflect the new font handling approach. - Adjusted display commands to improve clarity and functionality for GBK text rendering. - Refactored code for better readability and consistency, including changes in function parameters and variable names related to font handling. Files modified: 12
Deploying mentra-live-ota-site with
|
| Latest commit: |
fe71f2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d73fea64.mentra-live-ota-site.pages.dev |
| Branch Preview URL: | https://cole-gbk-test.mentra-live-ota-site.pages.dev |
Deploying mentra-store-dev with
|
| Latest commit: |
fe71f2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d04ed7a.augmentos-appstore-2.pages.dev |
| Branch Preview URL: | https://cole-gbk-test.augmentos-appstore-2.pages.dev |
Deploying dev-augmentos-console with
|
| Latest commit: |
fe71f2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://75a676e0.dev-augmentos-console.pages.dev |
| Branch Preview URL: | https://cole-gbk-test.dev-augmentos-console.pages.dev |
Deploying prod-augmentos-account with
|
| Latest commit: |
fe71f2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e7e76d2.augmentos-e84.pages.dev |
| Branch Preview URL: | https://cole-gbk-test.augmentos-e84.pages.dev |
- Introduced a new component for hinge fold detection, including the necessary CMake configuration and source files. - Implemented the hinge fold service in `mos_hinge_fold.c` and its header in `mos_hinge_fold.h`. - Updated `main.c` to initialize and start the hinge fold service. - Added new functions for hinge state management and configuration. Files modified: 6
- Removed PDM audio components and related configurations, transitioning to the GX8002 VAD for audio capture. - Updated device tree overlays to configure GPIOs for the GX8002 and adjusted I2C settings. - Introduced new shell commands for GX8002 control, including firmware version retrieval and I2S management. - Updated font handling to use only 18pt fonts to optimize FLASH usage. Files modified: 20
…into Cole_gbk_test
- Updated pointer declarations to use consistent spacing. - Reorganized function parameters for better alignment. - Added UTF-8 utility functions to check for ASCII and CJK characters. - Enhanced the rendering function for GBK characters to support text color. - Cleaned up comments and improved code structure for clarity. - Ensured thread safety in text updates and rendering processes.
Performance improvements: - Add batch glyph record read buffer to reduce SPI flash transactions (~165 reads/char → 1 read/char) - Implement LVGL label object pool (256 slots) for GBK text rendering - Add mutex-protected pending text buffer for deduplication - Add performance timing logs for UI updates Code cleanup: - Remove 471 lines of verbose protobuf debug logging - Remove 39 lines of I2S debug variables and macros - Refactor protobuf message type identification - Remove unnecessary C++ compatibility wrappers - Remove unused pool statistics variables Files modified: 6 Lines changed: +531 -670 (-139 net)
Include EN and ZH/EN font .bin and .hex artifacts under scripts so they can be uploaded and used directly for QSPI font provisioning. Made-with: Cursor
Clarify that font_en_* binaries in scripts are generated from the Red Hat Display family. Made-with: Cursor
Add font storage switching APIs/tests, integrate display-side language handling and shell controls, and update runtime/font configuration to support robust EN-first rendering during current rollout. Made-with: Cursor
- Added functions for setting stereo shift and software depth offset in a6n.h. - Updated prj.conf to remove unnecessary comments on LVGL display buffer settings. - Implemented a warning cache for advance width logging in mos_binfont_lvgl.c to suppress duplicate warnings. - Introduced new display commands for clearing the screen, invalidating full screen, and invalidating visible UI in mos_lvgl_display.h and mos_lvgl_display.c. - Added support for processing display distance configuration in protobuf_handler.c, mapping distance to software depth offsets. - Enhanced shell commands for display control, including depth adjustment, stereo shift, and distance settings. - Updated command help messages to reflect new functionalities.
- Refactor protobuf text throttling/commit flow into a shared helper to reduce duplicate logic. - Reduce protobuf text buffer size (768 chars) and keep pending/committed separation. - Add generic `GX8002_UPGRADE_ENABLE` switch so any GX8002 upgrade (v08/v09) compiles the required boot blob. Made-with: Cursor
- Updated app.overlay to disable GX8002 VAD path and enable PDM microphone configuration. - Modified CMakeLists.txt to include PDM components and exclude GX8002. - Adjusted prj.conf to reflect changes in audio configuration for PDM. - Refactored main.c and shell_audio_control.c to support PDM audio streaming and remove references to GX8002. - Enhanced audio control commands to reflect new PDM functionality and updated shell help messages. - Cleaned up unused code and comments related to the GX8002 integration.
Align LC3 encoder channel config with mono PCM path to reduce audio artifacts in PDM capture on evt1. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.