Skip to content

Conversation

DanChov
Copy link
Contributor

@DanChov DanChov commented Sep 8, 2025

upload summary and file list; include gpkg diff size and change count via safe helper; add real-diff test
#266

…le list; include gpkg diff size and change count via safe helper; add real-diff test; no change to success path
client_push.py removed unnecessary code, specified exceptions, added type hints
test_push_logging.py changeed to use real job
@DanChov DanChov requested review from varmar05 and removed request for MarcelGeo September 9, 2025 08:44
@coveralls
Copy link

coveralls commented Sep 10, 2025

Pull Request Test Coverage Report for Build 17668937757

Details

  • 76 of 81 (93.83%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 80.7%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mergin/test/test_push_logging.py 59 60 98.33%
mergin/client_push.py 17 21 80.95%
Files with Coverage Reduction New Missed Lines %
mergin/test/sqlite_con.py 10 0.0%
Totals Coverage Status
Change from base Build 17458681863: 0.2%
Covered Lines: 3596
Relevant Lines: 4456

💛 - Coveralls

@MarcelGeo
Copy link
Contributor

tests fixed

…and using real MerginProject in test_push_logging.py
@MarcelGeo MarcelGeo requested a review from varmar05 September 11, 2025 16:25
Copy link
Contributor

@varmar05 varmar05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 🎉

@varmar05 varmar05 merged commit 17c8ee0 into master Sep 12, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants