Upload changes limits #274
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max 10GB of non versioned files max 5GB of versioned files
varmar05
reviewed
Sep 12, 2025
varmar05
reviewed
Sep 12, 2025
| @@ -486,14 +486,17 @@ def get_push_changes_batch(mc, mp: MerginProject) -> Tuple[LocalChanges, int]: | |||
| updated=[LocalChange(**change) for change in changes["updated"]], | |||
| removed=[LocalChange(**change) for change in changes["removed"]], | |||
| ) | |||
| if local_changes.get_media_upload_size() > MAX_UPLOAD_MEDIA_SIZE: | |||
|
|
|||
| over_limit_media = local_changes.get_media_upload_over_size(MAX_UPLOAD_MEDIA_SIZE) | |||
There was a problem hiding this comment.
I liked your post_init approach, how about moving these checks to class as the first validation? We can also do both checks in single loop and raise custom validation error which will here trigger client error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #241