-
Notifications
You must be signed in to change notification settings - Fork 10
Basic conversion operators for humidity, temperature and pressure #1865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Conversions required, once basic code is done (excluding tests and full documentation will tick off) A set of conversion operators for different humidity variables to be stored under
A set of derived temperature operators in 'temperature.py':
A set of derived pressure operators in 'pressure.py':
|
5be21d9 to
e917bd6
Compare
|
Once full documentation done, will tick off. A set of conversion operators for different humidity variables to be stored under
A set of derived temperature operators in 'temperature.py':
A set of derived pressure operators in 'pressure.py':
|
|
Once tests done, will tick off. A set of conversion operators for different humidity variables to be stored under
A set of derived temperature operators in 'temperature.py':
A set of derived pressure operators in 'pressure.py':
|
dde531a to
667889d
Compare
1303099 to
c8c10a1
Compare
4e9fe99 to
0f9eaae
Compare
|
Recommendation is for a technical review and a science review. Suggested approach is to either review by commits or do each operator in turn as you see fit/as is easiest for you. |
Sylviabohnenstengel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for coding up this long list of conversions. I only have made few changes and happy to approve once a technical review has been conducted. I have put the emphasis of the review on the operators incl unit checks, equation checks etc. The tests look sensible to me i.e. checking metadata and physics, but i have not checked them in detail.
|
@daflack @jfrost-mo I have done the review and included a number of minor commits. Over to you @jfrost-mo for science and technical review and then happy to approve. Thank @daflack for coding up the long list of conversions! |
changed units of L_v amongst other small changes.
1a51ebf to
9ca4f63
Compare
Creates a series of basic conversion operators, not worrying about grid staggering or vertical levels at this point. The humidity, pressure, and temperature are all treated together due to the fact that they are strongly linked to each other and require the mix of code to be calculated.
Fixes #1852.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.