-
Notifications
You must be signed in to change notification settings - Fork 10
Remove ensemble loading heuristics #1888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We now rely on ensemble data having a `realization` coordinate. This allows for a significant simplification of the loading process. Fixes #1265
I think this was mostly working coincidentally, as the operations were also being done in-place. I do, however, expect that the `iris.util.squeeze(cube)` in _lfric_time_coord_fix_callback was not applied, which explains some issues we have been having.
This avoids making concatenating cubes difficult before we have done it.
d020b2e to
7cb7d26
Compare
|
@mo-tomosevans could you comment on this? I know you've been testing ensemble data |
|
Hi I think this is PR is something that could address problem I've encountered in #1845. Someone else reported something similar in #1808. You're right though @SGallagherMet - in the ensemble trial data I've been testing, the ensemble members are given as realization coordinates in the cubes for all but the control member (i.e. |
Am I right in thinking the control would be member 0? If so then it would have a realization coordinate added by the Is there any operational/trial ensemble data on disk that I could give this a test with? |
We now rely on ensemble data having a
realizationcoordinate.This allows for a significant simplification of the loading process.
Fixes #1808
Fixes #1845
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.