313 unify flag handling #504
Conversation
…to handle flags and path-flags.
…ler flags to support path-specific flags. Compute the hast as crc of the combined string (and not by adding three crc for three strings).
… used for ignore lists when converting DEPENDS dependencies to file dependencies.
…Fortran when searching for a default linker.
…313_unify_flag_handling
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…and made git's code quality and flake unhappy.
| if isinstance(new_flags, str): | ||
| self.append(new_flags) | ||
|
|
||
| class AlwaysFlags(AbstractFlags): |
|
This PR adds a set of classes to manage Flags. It allows one FlagList to be used everywhere, which can be a mixture of generic flags (that always apply) and path-specific flags. I have NOT changed the API of Fab itself, most steps take two flag lists (common flags and path flags). If we agree to change the API all these two arguments can be replaced with a single FlagList. Internally, the path flags are converted to the new MatchFlags, and all handling internally is with FlagList. @yaswant , @MatthewHambley , @Pierre-siddall, @t00sa , @cameronbateman-mo I did see the automatic comment that I am not calling the super class - the super class is an abstract class that has no implementation of init, and if I add , I get flake8 errors (this is already commented and closed, but it just got raised again). Let me know what I should do there :) |
This is getting reasonable stable, but it's currently blocked by #502 (which I need for kernel extraction in gungho). I will also verify that this works as expected with the UMm