update to use base_ref, not base_sha #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyhickson
approved these changes
Jan 26, 2026
Contributor
jennyhickson
left a comment
jennyhickson
left a comment
There was a problem hiding this comment.
LGTM. Confirmed offline that GITHUB_BASE_REF returns the expected values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CLA action the merge ref of a PR is currently compared against the Base SHA to see if the CONTRIBUTORS file has been modified in that branch.
This is incorrect as the merge ref may well contain additional commits since the Base SHA, some of which might change the CONTRIBUTORS, resulting in incorrect failures. Instead, use the Base Ref value, which returns the name of the target branch, and therefore we'll be comparing against the latest commit.