-
Notifications
You must be signed in to change notification settings - Fork 58
Add support for monsoon 3 #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is based on the changes in trac ticket #779. It also enables github personal access tokens by default on monsoon and defines an additional EX1A_WEIGHTS group to prevent undefined parent errors when running the ex1a group on monsoon.
james-bruten-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just removing those duplicated directives, otherwise all good I think
| NUMA_REGIONS_PER_NODE = 2 | ||
| LUSTRE_FILESYSTEM = true | ||
| ROSE_LAUNCHER = 'mpiexec' | ||
| [[[directives]]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid
james-bruten-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, over to @r-sharp
PR Summary
Sci/Tech Reviewer: @james-bruten-mo
Code Reviewer: @r-sharp
This is based on the changes in trac ticket #779. It also enables github personal access tokens by default on monsoon and defines an additional EX1A_WEIGHTS group to prevent undefined parent errors when running the ex1a group on monsoon.
Code Quality Checklist
Testing
Test suite also run on the monsoon 3 partition. Build tasks passed as expected, as did a number of model runs. Some test runs failed due to known problems with missing files in
$BIG_DATA_DIR.trac.log
Test Suite Results - lfric_apps - monsoon-branch/run1
Suite Information
Task Information
✅ succeeded tasks - 1106
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review