Generation of lfric2lfric lbcs #55
Conversation
github-actions
bot
added
cla-required
|
Hi Juan, I've just updated the base branch that this PR is targeting. Other than release bug fixes which will be done by an admin, all PRs are merged into main. Then stable remains representative of the release and somewhere to branch from for version branches. |
mo-lottieturner
added
the
LFRic Inputs
mike-hobson
left a comment
mike-hobson
left a comment
There was a problem hiding this comment.
I think this is fine. I've just made a few trivial comments/suggestions.
applications/lfric2lfric/rose-meta/lfric-lfric2lfric/HEAD/rose-meta.conf
Show resolved
Hide resolved
applications/lfric2lfric/source/driver/lfric2lfric_regrid_mod.F90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/initialisation/lfric2lfric_infrastructure_mod.X90
Outdated
Show resolved
Hide resolved
|
All changes suggested by the Sci/Tech reviewer have been implemented and tested. Trag log updated. |
mike-hobson
left a comment
mike-hobson
left a comment
There was a problem hiding this comment.
Thanks for those changes. I'm happy for this to pass to code review.
mo-lottieturner
left a comment
mo-lottieturner
left a comment
There was a problem hiding this comment.
Hi Juan - looks good, mostly cosmetic stuff to change. Once you've done that please update the branch and resolve conflicts so the GitHub Actions can run
applications/lfric2lfric/source/driver/lfric2lfric_driver_mod.F90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/driver/lfric2lfric_driver_mod.F90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/driver/lfric2lfric_init_mod.f90
Outdated
Show resolved
Hide resolved
ukmo-juan-castillo
force-pushed
the
lfric2lfric_lbc
branch
from
b618686 to
41e3776
Compare
github-actions
bot
added
cla-required
github-actions
bot
added
cla-signed
mo-lottieturner
left a comment
mo-lottieturner
left a comment
There was a problem hiding this comment.
Hi Juan - thanks for fixing that. Some more non-alphabetical corrections (sorry!) then we should be good to go
applications/lfric2lfric/source/driver/lfric2lfric_init_mod.f90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/driver/lfric2lfric_regrid_mod.F90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/driver/lfric2lfric_regrid_mod.F90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/initialisation/lfric2lfric_field_init_mod.f90
Outdated
Show resolved
Hide resolved
applications/lfric2lfric/source/initialisation/lfric2lfric_infrastructure_mod.X90
Outdated
Show resolved
Hide resolved
mo-lottieturner
left a comment
mo-lottieturner
left a comment
There was a problem hiding this comment.
Thanks Juan. Approved pending testing
4 participants
PR Summary
Sci/Tech Reviewer: @mike-hobson
Code Reviewer: @mo-lottieturner
This is the git version of svn ticket 1016: https://code.metoffice.gov.uk/trac/lfric_apps/ticket/1016
Lfric2lfric is now capable of generating lbc files. It reads a netcdf file containing a set of field timeseries, and regrids them into a destination mesh. At the moment the destination mesh is the full regional mesh, and in the output we have lbc values at the rim of the domain, and zeroes in the inside.
I had to create a dedicated clock for OASIS instead of using the modeldb clock, given that now we are reading a time series and we can not change the time at will. The source of data used to create lbcs is copied locally, so it will have to be copied to a central location. I could not link the clock ticking to file advance because this seems to work only for a single XIOS context, but we have two.
One of the existing KGOs had to be updated. The reason is that the KGO test was using the wrong mesh, and this error was introduced in ticket 621: https://code.metoffice.gov.uk/trac/lfric_apps/ticket/621
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
acceptable (eg. kgo changes)
tests, unit tests, etc.)
and have tests been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_apps - test_lfric2lfric_lbc/run1
Suite Information
Task Information
✅ succeeded tasks - 1461
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
inteface, optimisation scripts, LFRic data structure code) then please
contact the
tooscollabdevteam@metoffice.gov.uk
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review