Remove module scope access of namelist variables by coordinate/native jacobian. #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @mo-lucy-gordon
As part of work to remove configuration namelist access from module scope, configuration variables will need to be passed
by argument. Configuration variables passed by argument to kernels is more involved, so this PR moves the use _config_mod from the Jacobian routines up to the to the kernel level in preparation of further changes.
Linked PRs
MetOffice/lfric_apps#184
Code Quality Checklist
Testing
Rose test-suite Runs Green
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review