Skip to content

Conversation

@ericaneininger
Copy link

@ericaneininger ericaneininger commented Feb 4, 2026

PR Summary

Code Reviewer: @Pierre-siddall

Update MOCI rose-stem suite to pull from Git repositories for MOCI plus UM (and related repos).

Add shutdown handler to run suite_report to gain a trac.log file. Please note, the suite_report_git.py script called, which resides in the SimSys_Scripts repo, currently defaults to UM as primary source - hence slightly peculiar title in the report!

New lib/python directory is a direct copy from the UM rose-stem

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid undertanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the Moci rose-stem suite
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (eg. kgo changes)
  • I have added tests to cover new functionality as appropriate (eg. system
    tests, unit tests, etc.)

Test Suite Results - um - TEST_mociRS/run1

Suite Information

Item Value
Suite Name TEST_mociRS/run1
Suite User erica.neininger
Workflow Start 2026-02-04T11:30:07
Groups Run all
Dependency Reference Main Like
moci ericaneininger/moci@rose_stem_git False
casim MetOffice/casim@um13.1 True
jules MetOffice/jules-internal@um13.1 True
shumlib MetOffice/shumlib@um13.1 True
socrates MetOffice/socrates@um13.1 True
ukca MetOffice/ukca@um13.1 True
um MetOffice/um@vn13.1 True

Task Information

✅ succeeded tasks - 116

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Feb 4, 2026
@github-actions github-actions bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant