feat(analytics-controller): update controller and adapter interface for mobile integration [Phase 1.4] #7080
+455
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add onSetupCompleted lifecycle hook to AnalyticsPlatformAdapter interface - Remove add method from interface (breaking change) - Change AnalyticsPlatformAdapter from type alias to interface - Add UUIDv4 validation for analyticsId with error handling - Add AnalyticsUserTraits type for better semantic separation - Rename trackEvent to track and trackPage to view in adapter interface - Update controller to call onSetupCompleted after initialization - Add comprehensive tests for lifecycle hook and validation - Update documentation with lifecycle hook usage examples
NicolasMassart
changed the title
…y method - Add isOptedIn method and corresponding action type - Refactor identify method to use analyticsId from state instead of userId parameter - Update tests to use realistic traits (ENABLE_OPENSEA_API, NFT_AUTODETECTION) instead of email - Update UUID test example from v1 to v5 - Remove obsolete tests - Fix formatting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is an unreleased package which will continue to be improved until ready for release.
Explanation
Added
onSetupCompletedlifecycle hook for post-initialization setupAdded UUIDv4 validation for analyticsId
Added getter methods:
getAnalyticsId(),isEnabled(),isOptedIn()Added
AnalyticsPlatformAdapterSetupErrorfor setup failuresMade identify and view required in
AnalyticsPlatformAdapterRenamed controller method:
trackPage→trackViewfor platform agnostic usageRenamed adapter type method:
trackEvent→trackto better match Segment SDKsRefactored
identify: removeduserIdparameter, usesanalyticsIdfrom state, addedAnalyticsUserTraitstypeUpdated action types for new methods and renames
Updated tests for new API and lifecycle hook
Updated README with lifecycle hook documentation
References
fixes #7079
Checklist