-
-
Notifications
You must be signed in to change notification settings - Fork 256
feat: bridge popular and search getTokens endpoints #7120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
micaelae
wants to merge
9
commits into
main
Choose a base branch
from
swaps3224-asset-picker-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+727
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Introduce
fetchPopularTokensandfetchTokensBySearchQuerywith newBridgeAssetV2type, addchainRankingto feature flags, and update exports and tests accordingly.fetchPopularTokensto retrieve ranked tokens (optionally merged with user balances) from/getTokens/popular.fetchTokensBySearchQueryfor paginated search from/getTokens/search, merging balances and handling cursors.BridgeAssetV2andTokenBalancetypes; addBridgeAssetV2SchemaandvalidateSwapsAssetV2Object.CaipChainIdStructin schemas where applicable.chainRankingtoPlatformConfigSchemaand include in defaults (DEFAULT_FEATURE_FLAG_CONFIG).chainRankinghandling.BridgeAssetV2, controller event/action types) and fetch functions (fetchPopularTokens,fetchTokensBySearchQuery).chainRanking.Written by Cursor Bugbot for commit 4a10c25. This will update automatically on new commits. Configure here.