feat: select MetaMask provider when conflicts with Coinbase Wallet#66
Open
VGLoic wants to merge 2 commits intoMetaMask:mainfrom
Open
feat: select MetaMask provider when conflicts with Coinbase Wallet#66VGLoic wants to merge 2 commits intoMetaMask:mainfrom
VGLoic wants to merge 2 commits intoMetaMask:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Coinbase Wallet and MetaMask extensions are both installed, the Coinbase Wallet Extension will modify the ethereum object of the window. According to their documentation, the advised solution is to loop over the new ethereum.providers field in order to find the proper provider.
This PR includes the advised changes.
Codesandbox for the issue: https://codesandbox.io/s/charming-burnell-x7jqq7?file=/src/App.tsx
Resolves #53