Skip to content

chore: Migrate from Yarn v1 to v4#124

Merged
Gudahtt merged 1 commit intomainfrom
migrate-yarn-v4
Feb 12, 2025
Merged

chore: Migrate from Yarn v1 to v4#124
Gudahtt merged 1 commit intomainfrom
migrate-yarn-v4

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 12, 2025

Migrate to Yarn v4 using the module template as guidance. Minimal changes have been made to the GitHub Actions workflows, just enough to get this working.

@socket-security
Copy link

socket-security bot commented Feb 12, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@isaacs/fs-minipass@4.0.1 filesystem 0 101 kB isaacs
npm/@metamask/auto-changelog@2.6.1 🔁 npm/@metamask/auto-changelog@2.5.0 None 0 150 kB gudahtt
npm/rimraf@5.0.10 environment, filesystem 0 281 kB isaacs

View full report↗︎

@socket-security
Copy link

socket-security bot commented Feb 12, 2025

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/negotiator@1.0.0, npm/unique-slug@5.0.0, npm/abbrev@3.0.0, npm/@npmcli/fs@4.0.0, npm/unique-filename@4.0.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

- name: Get Yarn version
run: echo "::set-output name=YARN_VERSION::$(yarn --version)"
id: yarn-version
- name: Cache yarn dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I omitted the caching, since we recently removed that from publishing workflows in the module template as well.

@Gudahtt Gudahtt force-pushed the migrate-yarn-v4 branch 7 times, most recently from 3cee110 to 5f4fd0d Compare February 12, 2025 14:33
@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 12, 2025

@SocketSecurity ignore npm/negotiator@1.0.0
@SocketSecurity ignore npm/unique-slug@5.0.0
@SocketSecurity ignore npm/abbrev@3.0.0
@SocketSecurity ignore npm/@npmcli/fs@4.0.0
@SocketSecurity ignore npm/unique-filename@4.0.0

New author is OK (npm bot)

Migrate to Yarn v4 using the module template as guidance. Minimal
changes have been made to the GitHub Actions workflows, just enough to
get this working.
"@lavamoat/allow-scripts": "^3.0.4",
"@lavamoat/preinstall-always-fail": "^2.0.0",
"@metamask/auto-changelog": "^2.5.0",
"@metamask/auto-changelog": "^2.6.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to bump to 2.6 to get support for Yarn berry: https://github.com/MetaMask/auto-changelog/blob/main/CHANGELOG.md#260

@Gudahtt Gudahtt marked this pull request as ready for review February 12, 2025 15:17
Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt merged commit b87ad9a into main Feb 12, 2025
12 checks passed
@Gudahtt Gudahtt deleted the migrate-yarn-v4 branch February 12, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants