fix(zero-warnings): tackle easy lint warnings #3#40821
Open
fix(zero-warnings): tackle easy lint warnings #3#40821
Conversation
Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
…rer and snap-ui-radio-group Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
…S2322 errors Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
Fix 20 ESLint warnings across 11 files: - Remove unused prop types (react/no-unused-prop-types) - Add missing key props (react/jsx-key) - Escape unescaped entities (react/no-unescaped-entities) - Clean up test types in with-router-hooks tests Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix zero warnings: Tackle easy lint warnings
fix(zero-warnings): tackle easy lint warnings #3
Mar 11, 2026
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (5 files, +3 -3)
🫰 @MetaMask/core-platform (1 files, +1 -0)
|
HowardBraham
added
team-extension-platform
Copilot stopped work on behalf of
HowardBraham due to an error
March 11, 2026 22:57
Co-authored-by: HowardBraham <539738+HowardBraham@users.noreply.github.com>
|
Contributor
Builds ready [aea11ba]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI Prompt
main, merge incopilot/fix-lint-warningsandcopilot/fix-easy-lint-warningsyarn lintto see the current warning count. Your PR branch must be based on cleanmain— do NOT push the merges. Before pushing, rungit diff --name-only origin/main HEADand verify the file list matches only your ~10 intended files. Count codeowners against that full list, not just your last commit.yarn lintand read all the warnings (this command is going to take at least 15 minutes to complete, so wait for it, and please report the number of warnings)yarn linton this after your changes. Runningyarn lint:changed:fixis not enough, because it only runs eslint, and does not run tsc.fix(zero-warnings): tackle easy lint warnings #3## AI PromptWarnings: 198 → 178 (−20)
Eliminates 20 ESLint warnings across 11 files. 1 codeowner team (
@MetaMask/confirmations× 5 files) + 6 files with no codeowner.react/no-unused-prop-types— 14 warningsisPermitfrom inline typeplaceholderfrom propsactiveTabOriginfromConnectPagePropsand all call sites; drop staleoriginfromuseCallbackdepstestPropinto only the component that uses it; removerenderCountintersection type from 5 inner test componentsreact/jsx-key— 3 warningskey="symbol"on<b>in translation array<StateChangeRow>in.flatMap().map()key="snap-name"on<Text>in translation arrayreact/no-unescaped-entities— 2 warnings"→"Stale
useCallbackdep — 1 warningoriginfrom deps array after removing its only usage in the callback body🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.
Note
Low Risk
Low risk lint/React warning cleanup (unused props/types, missing React keys, and escaped entities) with no behavioral changes expected beyond removing unused
ConnectPageprop wiring.Overview
Reduces
yarn lintwarnings by cleaning up easy React/TypeScript issues across confirmations and permissions-connect UI.Removes unused props/type intersections (e.g., drops
activeTabOriginfromConnectPagePropsand updates stories/tests/call sites, and simplifies HOC test component prop typing), adds missingkeyprops for translated JSX arrays and mapped rows, and escapes a raw quote string to satisfyreact/no-unescaped-entities.Written by Cursor Bugbot for commit aea11ba. This will update automatically on new commits. Configure here.