Skip to content

chore(vscode): replace deprecated workspace settings keys#40823

Draft
davidmurdoch wants to merge 1 commit intomainfrom
chore/update-deprecated-vscode-settings-keys
Draft

chore(vscode): replace deprecated workspace settings keys#40823
davidmurdoch wants to merge 1 commit intomainfrom
chore/update-deprecated-vscode-settings-keys

Conversation

@davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Mar 11, 2026

Description

Open in GitHub Codespaces

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Mar 11, 2026
@sonarqubecloud
Copy link

@metamaskbotv2
Copy link
Contributor

metamaskbotv2 bot commented Mar 11, 2026

Builds ready [7b0c701]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29827933822307338
total29827933822307338
Confirm Txconfirm_tx6026598360553060526055
total6026598360553060526055
Bridge User Actionsbridge_load_page23920426224261262
bridge_load_asset_picker23721626719245267
bridge_search_token75773377616765776
total1238121012832812361283
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14541228182110615101626
load1210100415269612541379
domContentLoaded120399915179512501371
domInteractive291798172679
firstPaint165731363177201287
backgroundConnect21719828416219257
firstReactRender20134862135
initialActions105113
loadScripts100380513059310521168
setupStore1576291631
numNetworkReqs362785173679
Power User HomeuiStartup5264213511063203164878631
load13231148189612913421655
domContentLoaded12991143186812213201587
domInteractive3819206293597
firstPaint231891214137291394
backgroundConnect16923027268155726394729
firstReactRender26194052835
initialActions103112
loadScripts1071930162611810871359
setupStore1664161931
numNetworkReqs1457730340151227
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2202182232220223
srpButtonToSrpForm92909529395
confirmSrpToPwForm22212202222
pwFormToMetricsScreen15151501515
metricsToWalletReadyScreen15151601516
doneButtonToHomeScreen67160177962691779
openAccountMenuToAccountListLoaded2925291029361129342936
total3965389840757239814075
Onboarding New WalletcreateWalletToSocialScreen2212182242222224
srpButtonToPwForm1101071132111113
createPwToRecoveryScreen989099
skipBackupToMetricsScreen36363703637
agreeButtonToOnboardingSuccess17171801718
doneButtonToAssetList471308684130501684
total80869789182883891
Asset DetailsassetClickToPriceChart594481145681
total594481145681
Solana Asset DetailsassetClickToPriceChart1267121651145216
total1267121651145216
Import Srp HomeloginToHomeScreen2330225723795323792379
openAccountMenuAfterLogin52415775757
homeAfterImportWithNewWallet1836644227068922342270
total43713640467942546184679
Send TransactionsopenSendPageFromHome29273123131
selectTokenToSendFormLoaded31243763637
reviewTransactionToConfirmationPage1074696137622911861376
total1136747142923112431429
SwapopenSwapPageFromHome973315244137152
fetchAndDisplaySwapQuotes269026872693226912693
total2793272428575028392857
🌐 Dapp Page Load Benchmarks

Current Commit: 7b0c701 | Date: 3/11/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±43ms) 🟡 | historical mean value: 1.05s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 735ms (±62ms) 🟢 | historical mean value: 740ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 92ms (±128ms) 🟢 | historical mean value: 85ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 43ms 1.02s 1.37s 1.07s 1.37s
domContentLoaded 735ms 62ms 710ms 1.29s 757ms 1.29s
firstPaint 92ms 128ms 64ms 1.36s 88ms 1.36s
firstContentfulPaint 92ms 128ms 64ms 1.36s 88ms 1.36s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -609 Bytes (-0.01%)
  • ui: 14.2 KiB (0.17%)
  • common: -559 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size-XS team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants