[#1446] Implement toMessage to leverage message parts#1674
Draft
[#1446] Implement toMessage to leverage message parts#1674
toMessage to leverage message parts#1674Conversation
JPMeehan
reviewed
Feb 23, 2026
Comment on lines
+30
to
+34
| [foundry.utils.randomID()]: { | ||
| flavor: messageData.flavor, | ||
| rolls: [this], | ||
| type: this.constructor.PART_TYPE, | ||
| }, |
Contributor
There was a problem hiding this comment.
Isn't _id required? I've just been leaning on our migrateData function to generate an ID and use it for the key and _id value
| author: game.user.id, | ||
| sound: CONFIG.sounds.dice, | ||
| }, messageData); | ||
| messageData.system.parts = { |
Contributor
There was a problem hiding this comment.
I suspect we will need to make it easier for subclasses to adjust this chunk of data.
| * The type used for the `part` of a standard message. | ||
| * @type {string} | ||
| */ | ||
| static PART_TYPE = ""; |
Contributor
There was a problem hiding this comment.
Shouldn't the base case be just creating a single roll part?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
toMessageon the baseDSRollclass. Subclasses should definePART_TYPE.Closes #1446.