Artisan and Sage data model, rudimentary sheet.#1676
Open
JPMeehan wants to merge 3 commits intofollowers/679-artisan-sagefrom
Open
Artisan and Sage data model, rudimentary sheet.#1676JPMeehan wants to merge 3 commits intofollowers/679-artisan-sagefrom
JPMeehan wants to merge 3 commits intofollowers/679-artisan-sagefrom
Conversation
krbz999
reviewed
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
679-artisan-sagewill function as a feature branch for work on Sages & Artisans until we're ready to merge to /develop as part of 0.11 development.This pull request represents work on the Followers's data model. While working on it I ran into an important question about roll data structure — I think it's correct to have
@item.Ato reference the followers Agility, with the root@Abeing reserved for the owning hero.