Skip to content

[#1364] Move skills to top level of system data#1680

Draft
JPMeehan wants to merge 1 commit intodevelopfrom
move-skills
Draft

[#1364] Move skills to top level of system data#1680
JPMeehan wants to merge 1 commit intodevelopfrom
move-skills

Conversation

@JPMeehan
Copy link
Contributor

  1. We've got more general need to have it be skills.value so there can be the already-prepared skills.list and skills.modifiers
  2. While normal NPCs don't have skills, there's enough other actor types like Companions that have skills. This also jives better with our expected Follower data.

@JPMeehan JPMeehan added this to the v0.11.0 milestone Feb 24, 2026
@JPMeehan JPMeehan requested a review from krbz999 February 24, 2026 06:53
@JPMeehan JPMeehan self-assigned this Feb 24, 2026
@JPMeehan JPMeehan added the data model Document and Data Model issues label Feb 24, 2026
@JPMeehan JPMeehan linked an issue Feb 24, 2026 that may be closed by this pull request
@krbz999
Copy link
Member

krbz999 commented Feb 24, 2026

Good idea, but let's add shims to AEs with deprecation period until 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data model Document and Data Model issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider migrating skills outside of hero

2 participants