Skip to content

Conversation

@lontivero
Copy link
Contributor

No description provided.

@NicolasDorier
Copy link
Collaborator

@lontivero you may want to take a look at #696 from @joemphilips

I was planning to merge it, but I don't think anyone wanted to use it immediately, so I kept the PR open waiting for the opportunity.

@joemphilips
Copy link
Contributor

joemphilips commented Aug 24, 2020

I abandoned my attempt because miniscript/output-descriptor spec was continuously being rebuilt from scratch. So I'm happy if @lontivero is taking after me. I was exhausted by keep scratching my head around for prototypical miniscript.

My attempt was based on rust-miniscript, by I recommend to port from C++ version. It seemed more concise than rust version.

@NicolasDorier
Copy link
Collaborator

@joemphilips even the miniscript one if I understood is constantly changing? I thought the output descriptors were kind of stable.

@joemphilips
Copy link
Contributor

@NicolasDorier The spec for the miniscript contained new version of output-descriptor and that was not stable when I was playing around. The restricted version of output-descriptor (which we already have in bitcoin-rpc) is stable, I guess.

@lontivero
Copy link
Contributor Author

Ohhh! I didn't know about @joemphilips' PR. I've just scrolled up and down his PR and it looks good (that functional approach in the code is cool btw). I can take it and make some progress on top. I cannot promise anything but i will try.

@lontivero lontivero closed this Aug 24, 2020
@joemphilips
Copy link
Contributor

Speaking of #696 , this contains the restricted version of output descriptor, which works fine and passes every tests in bitcoin-core. But if i could start from scratch, I will probably not use Parser combinator. functional parser combinator is a great tool in functional-first language such as F# but in C# it is hard to read/debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants