Don't show the CP movement for questions not old enough #3739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbmtc
approved these changes
Nov 4, 2025
hlbmtc
requested changes
Nov 4, 2025
questions/utils.py
Outdated
| is_above_2_weeks = question_age >= timedelta(days=14) | ||
|
|
||
| is_open = question.status == QuestionStatus.OPEN | ||
| forecasters_count = question.get_forecasters().count() |
Contributor
There was a problem hiding this comment.
This will introduce an N+1 query and could lead to performance issues, especially since it’s used in serialize_question_movement, which gets called in many places where we render multiple questions at once
The question should either be more than 2 weeks old, or have at least 20 forecasters
hlbmtc
reviewed
Nov 7, 2025
| forecasts_count=SubqueryAggregate("forecast", aggregate=Count) | ||
| ) | ||
|
|
||
| def annotate_forecasters_count(self): |
Contributor
There was a problem hiding this comment.
This makes sense, but I do have some concerns about the potential performance overhead.
Ideally, we could introduce a cached field on the Question model (similar to Post.forecasters_count and Post.update_forecasters_count) that's updated during the forecasting process. That way, we avoid recalculating it repeatedly, and it could also be useful for other features.
WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The question should either be more than 2 weeks old, or have at least 20 forecasters
Closes #3725