-
-
Notifications
You must be signed in to change notification settings - Fork 23
Release 3.0 #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Release 3.0 #61
Conversation
|
Am I crazy, or does Meteor itself already support postcss? AFAIK it's already supported without external packages, see this PR from zodern. |
|
😵 why didn't I know this... is this mentioned in the docs? Anyway I just did it as a sideeffect for a migration article (which you will see soon 😆) but I think for the sake of support we should make this package at least compatible with 3.0. Maybe adding a warning or something with hint to the respective docs page? |
|
Ok, good that I'm not crazy hehe I think this package is no longer necessary so it should display a warning about that fact so people can use the standard one. I don't think we should have a version of it for Meteor 3. |
|
I just tested with the tailwind example that I updated to 3.0 Alpha 19 - you can't simply remove this and add |
|
CodeFTW uses tailwind and it's working. Packages: release: METEOR@3.0-alpha.19 Tailwind.config.js .postcssrc.js |
|
Quave's meteor-template as well https://github.com/quavedev/meteor-template/tree/meteor-3 |
|
@jankapunkt were you able to find the problem in your example project? |
|
Are there any blockers to merge this and release a new version? |
|
@jankapunkt what is the status here? If everything is fine on your end I'm happy to release. |
|
cc @jankapunkt @StorytellerCZ Can we a beta release that's compatible with the latest RC? |
|
So i cannot publish due to an error I don't understand: => Errors while initializing project:
While loading plugin `minifier-postcss` from package `juliancwirko:postcss`:
packages/modules-runtime.js:222:12: Cannot find module 'postcss'
at makeMissingError (packages/modules-runtime.js:222:12)
at Module.require (packages/modules-runtime.js:241:17)
at Module.moduleLink
(/home/jankapunkt/.meteor/packages/modules/.0.20.0.17ptybp.ylkxi++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/@meteorjs/reify/lib/runtime/index.js:52:22)
at packages/minifier-postcss/plugin/minify-css.js:1:21
at module (packages/minifier-postcss/plugin/minify-css.js:260:2)
at fileEvaluate (packages/modules-runtime.js:336:7)
at Module.require (packages/modules-runtime.js:238:14)
at require (packages/modules-runtime.js:258:21)
at <runJavaScript-21>:301:1
at <runJavaScript-21>:306:3Seems to be related to #15 but I don't know how to get around this |
We moved our tailwind project from meteor 2 with juliancwirko:postcss to meteor 3.0rc0 with standard-minifier-css successfully. So instead, I think this package should be removed from Meteor-Community-Packages to avoid even more confusion or at least in tell in the doc that it's not needed with meteor 3 with a link to the doc |
This PR removes the Fibers dependency and uses async/await instead.
Also fixes package dependency conflicts.
Note: I could have rewritten a lot to ES6 and bump NPM dependencies but I would rather do that in the next PRs.