-
-
Notifications
You must be signed in to change notification settings - Fork 75
Feature/remove sass direct dependency #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove sass direct dependency #328
Conversation
* master: Internal Meteor Packages: improve root file detection logic for imports and package files Meteor-Community-Packages#324
fully tested!
Addressed an issue where running `meteor test-packages` in Meteor 2 failed due to npm dependency installation errors related to the `meteor-node-stubs` update. This fix ensures compatibility and resolves the 'npmignore: command not found' error during package tests. For more details, see: meteor/meteor#13691
- Removed `sass` as a direct dependency to allow full control over Sass versioning - Enables usage of both `sass` and `sass-embedded` via devDependencies - Updated README.md for improved clarity, examples, and migration guidance - Bumped version to `5.1.0-beta.1` to reflect breaking internal change
…ckage tests" This reverts commit 122359f.
|
Hi @StorytellerCZ @jankapunkt 👋 I know the previous PR #323 is still pending and this one is not urgent yet — there’s still a long way to go before it would need deeper attention. That said, I just wanted to check in and ask: No pressure at all, I completely understand if priorities are elsewhere. I’d just appreciate any early thoughts before investing more energy into refining this path. Thanks a lot! 🙏 |
|
If anything this would have to be a major version as it requires an action from the package users. |
|
@StorytellerCZ I didn’t include it in That said, I’m still waiting for a bit more feedback from you to validate both the direction and the implementation itself. If you feel this change belongs in |
Hey, Do you think it makes sense to roll this change into Let me know what you think! |
|
I am pro major versions if things are indeed breaking and I'm ready to review any more PR or publish a new beta/rc |
|
Great — thanks for confirming! In that case, I’ll go ahead and rework this PR to target Do you have any suggestions on how to best structure this so the development history stays clear and old context doesn't create confusion? Would you prefer that I:
Also, would a quick cleanup of outdated/inconsistently named branches be helpful at this point? Lastly, there are a couple of issues that were resolved as part of Let me know what works best for you — I’ll adjust accordingly! |
|
Hey @illusionfield I'm blocked this week for something else, hopefully I can get back to this in between things... @StorytellerCZ do you have an opinion on the proposed options? |
|
Please target the |
|
Perfect, thanks! The two resolved issues are:
I'll go ahead and close the two existing PRs and open a new one targeting the I'll link the new PR shortly. |
|
Closing this PR in favor of the consolidated version here: That PR targets |
Closing this PR in favor of the consolidated version here:
➡️ #329 – Finalize Dart Sass migration & drop direct dependency
That PR targets
release/5.0.0and includes all changes from this one, along with updated docs and migration instructions.Looking forward to your feedback there!
This PR introduces
v5.1.0-beta.1with a key internal change:sassis no longer declared as a direct dependency.Instead, users can now choose their own Sass engine (
sassorsass-embedded) and version vianpm.What's Changed
🔧 Removed built-in dependency on
sassGives full control to developers to pin versions, choose implementation, or upgrade independently.
📚 Improved README.md
sassandsass-embedded🆙 Version bump to
v5.1.0-beta.1Reflects an internal change that may affect build behavior for some users.
Migration Notes
Users upgrading to
v5.1.0-beta.1must now manually install a Sass compiler:meteor npm install --save-dev sass # or meteor npm install --save-dev sass-embeddedWhy This Matters
This decoupling makes the package:
sass-embedded),