Skip to content

Conversation

@bangyro
Copy link
Collaborator

@bangyro bangyro commented Jan 19, 2026

No description provided.

@bangyro bangyro force-pushed the feat/add-common-protocol-fee branch from 2132c76 to f68848a Compare January 20, 2026 08:03
@bangyro bangyro changed the base branch from main to release_0.2.2 January 20, 2026 08:03
@bangyro bangyro marked this pull request as ready for review January 20, 2026 10:26
@@ -0,0 +1,11 @@
[package]
name = "protocol-zap"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets rename it to zap-sdk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and separate the code:

  • To be used in zap-program
  • To be used in protocol-zap

Copy link
Collaborator Author

@bangyro bangyro Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if this is what you have in mind. So there will be zap-sdk, which zap-program and protocol-zap depends on?

zap-sdk -> common code used by zap-program/protocol-zap
protocol-zap -> common code used by other programs to zap protocol fee

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes


[dependencies]
anchor-lang = { workspace = true }
anchor-spl = { workspace = true }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we can make it no anchor dependencies, so it is easier to being imported from other projects?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing you are replacing it by solana dependencies, is this possible to replace it by pinocchio?
https://github.com/anza-xyz/pinocchio

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove those dependencies:

solana-account-info = "2"
solana-instruction = "2"
solana-program = "2"
solana-program-error = "2"
solana-pubkey = "2"
spl-associated-token-account = "6"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants