-
Notifications
You must be signed in to change notification settings - Fork 2
feat/add common protocol fee #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release_0.2.2
Are you sure you want to change the base?
Conversation
2132c76 to
f68848a
Compare
protocol-zap/Cargo.toml
Outdated
| @@ -0,0 +1,11 @@ | |||
| [package] | |||
| name = "protocol-zap" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets rename it to zap-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and separate the code:
- To be used in zap-program
- To be used in protocol-zap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if this is what you have in mind. So there will be zap-sdk, which zap-program and protocol-zap depends on?
zap-sdk -> common code used by zap-program/protocol-zap
protocol-zap -> common code used by other programs to zap protocol fee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
protocol-zap/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| anchor-lang = { workspace = true } | ||
| anchor-spl = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we can make it no anchor dependencies, so it is easier to being imported from other projects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing you are replacing it by solana dependencies, is this possible to replace it by pinocchio?
https://github.com/anza-xyz/pinocchio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove those dependencies:
solana-account-info = "2"
solana-instruction = "2"
solana-program = "2"
solana-program-error = "2"
solana-pubkey = "2"
spl-associated-token-account = "6"
No description provided.