Skip to content

Test on all supported PHP versions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spaze wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Test on all supported PHP versions #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3f6e367
Remove config.platform.php
spaze Nov 28, 2025
f693052
Test on all supported PHP versions
spaze Nov 28, 2025
b104cef
Remove empty namespacesRequiredToUse phpcs config
spaze Nov 28, 2025
dc11d05
Consistence config was moved to a local file in phpstan/build-cs
spaze Nov 28, 2025
33ced32
substr() returns an empty string on PHP 8.x where it previously retur…
spaze Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"
- "8.5"

steps:
- name: "Checkout"
Expand Down Expand Up @@ -87,6 +90,9 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"
- "8.5"
dependencies:
- "lowest"
- "highest"
Expand Down Expand Up @@ -124,6 +130,9 @@ jobs:
- "8.0"
- "8.1"
- "8.2"
- "8.3"
- "8.4"
- "8.5"
dependencies:
- "lowest"
- "highest"
Expand Down
3 changes: 0 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
"phpunit/phpunit": "^9.5"
},
"config": {
"platform": {
"php": "7.4.6"
},
"sort-packages": true
},
"extra": {
Expand Down
6 changes: 2 additions & 4 deletions phpcs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@
<arg name="cache" value="build-cs/tmp/phpcs"/>
<arg value="sp"/>

<rule ref="build-cs/vendor/consistence-community/coding-standard/Consistence/ruleset.xml">
<rule ref="build-cs/consistence.xml">
<exclude name="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.InvalidFormat"/>
<exclude name="SlevomatCodingStandard.Commenting.InlineDocCommentDeclaration.MissingVariable"/>
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation"/>
<exclude name="SlevomatCodingStandard.Namespaces.FullyQualifiedExceptions"/>
<exclude name="Consistence.Exceptions.ExceptionDeclaration"/>
<exclude name="Squiz.Commenting.FunctionComment"/>
<exclude name="Squiz.PHP.Heredoc.NotAllowed"/>
<exclude name="Squiz.WhiteSpace.FunctionSpacing.Before"/>
Expand Down Expand Up @@ -87,7 +86,6 @@
<rule ref="SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly">
<properties>
<property name="searchAnnotations" value="true"/>
<property name="namespacesRequiredToUse" value=""/>
<property name="allowPartialUses" value="true"/>
<property name="allowFallbackGlobalFunctions" value="false"/>
<property name="allowFallbackGlobalConstants" value="false"/>
Expand All @@ -109,7 +107,7 @@
</properties>
</rule>
<rule ref="PSR1.Methods.CamelCapsMethodName.NotCamelCaps"/>
<rule ref="Consistence.NamingConventions.ValidVariableName.NotCamelCaps"/>
<rule ref="Squiz.NamingConventions.ValidVariableName.NotCamelCaps"/>
<exclude-pattern>tests/*/data</exclude-pattern>
<exclude-pattern>tests/*/data-attributes</exclude-pattern>
</ruleset>
6 changes: 6 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ parameters:
path: '*/Nette/LinkChecker.php'
reportUnmatched: false
count: 1
-
message: '#Strict comparison using === between non-empty-string and false will always evaluate to false\.#'
identifier: identical.alwaysFalse
path: '*/Nette/LinkChecker.php'
reportUnmatched: false
count: 1