feat: add standalone verifyWebhookSignature helper to SDK#351
Open
dinahmaccodes wants to merge 5 commits intoMetroLogic:mainfrom
Open
feat: add standalone verifyWebhookSignature helper to SDK#351dinahmaccodes wants to merge 5 commits intoMetroLogic:mainfrom
dinahmaccodes wants to merge 5 commits intoMetroLogic:mainfrom
Conversation
|
@dinahmaccodes Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #331
Closes #305
Changes:
Added a standalone
verifyWebhookSignature(rawBody, signature, timestamp, secret, options?)function to the SDK that matches the backend's HMAC-SHA256 signing format exactly (${timestamp}.${rawBody}). It includes replay-protection via a configurable tolerance window, constant-time comparison, and returns a typed{ valid, error? }result. The existingclient.webhooks.verify()method now delegates to it. The function is exported directly from@fluxapay/sdk.For #305, added
SorobanQueueService— an in-process queue that serializes Soroban contract submissions and retries with exponential back-off (up to 3 attempts).PaymentService.verifyPaymentnow enqueues the on-chain call non-blocking instead of awaiting it directly, so the payment confirmation flow is no longer blocked by RPC latency.Also fixed a pre-existing file corruption in
paymentMonitor.streaming.minimal.ts(literal\nstrings instead of real newlines) that was breaking the TypeScript build.Checklist:
verifyWebhookSignaturestandalone helper implemented${timestamp}.${rawBody})@fluxapay/sdkpackage entryPaymentService.verifyPaymentuses queue (non-blocking)issue-something