Conversation
|
@JoYvBa Have a quick look at the rendering if you like (you can try it locally with |
|
This looks great, documentation really takes shape like this! Also makes it easier to spot mistakes in the examples. I spotted a few, most of which are easily fixed. There are also some things not rendering properly;
Perhaps good idea to merge this after my documentation pull request, then we can do everything right in one go! |
…ry to make latex equations render in markdown cells
…amples dir with two notebooks to illustrate the rendering. T. This can be sorted out after Jorrit finishes the documentation PR
e0f9de7 to
57134ef
Compare
|
Thanks for the review! I managed to get the equations to render, but it looks like the animations will have to wait. As we discussed today, I will merge this now and then we can adapt the documentation PR a bit (I think we agreed we will move animations to a python script, rather than notebook, so perhaps we can get the animations that way instead). |
JoYvBa
left a comment
There was a problem hiding this comment.
@raar1 Looks good Robin, thanks for getting this to work! Animations will indeed have to be done through regular scripts, their behavior in the notebooks is too volatile. Better have something robust than something that breaks every so often (or specifically here; not rendering at all).
JaroCamphuijsen
left a comment
There was a problem hiding this comment.
Looks good @raar1, as we discussed, maybe check whether we can only execute the notebooks when deploying the documentation instead of upon every commit.
…entation test builds
|
|
There does not appear to be any way to pass the parameters to the commandline tool (especially not a parameter of a plugin). So I think the only way to do this is to add a CI step that modifies the I've done this with a python script that does at least some checks (so it's slightly less hacky...) |



Adds notebook rendering to the documentation using an mkdocs plugin. Notebooks are now in an examples directory within
docs/. The notebooks that are included can be configured in themkdocs.yml.Fixes #114