Conversation
Collaborator
KiLanger
commented
May 28, 2024
KiLanger
commented
- Added CVC to payment registration with payment provider
- Made TS config more strict and fixed upcoming issues
- Added exposed configuration and retries for requests to simulation service
added 9 commits
May 15, 2024 16:48
nk-coding
requested changes
Jun 4, 2024
Contributor
nk-coding
left a comment
nk-coding
left a comment
There was a problem hiding this comment.
sry that it took so long
| DATABASE_URI: mongodb://payment-db:27017 | ||
| DATABASE_NAME: misarch | ||
| SIMULATION_URL: http://simulation:8080 | ||
| PAYMENT_PROVIDER_URL: http://simulation:8080/payment/register |
Contributor
There was a problem hiding this comment.
didn't we discuss to move this to infrastructure-docker instead?
| import { RejectionReason } from './order-rejection-reason'; | ||
| import { OrderItemDTO } from './order-item.dto'; | ||
|
|
||
| export class PaymentAuthorization { |
| switch (paymentMethod) { | ||
| case PaymentMethod.CREDIT_CARD: | ||
| return this.creditCardService.create(id, amount); | ||
| if (!paymentAuthorization) { throw new Error('Authorization missing') } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.