Merged
Conversation
Dead-end insulator TEs were using SIDE_MOUNT geometry (Y:0-0.6875) but dead-end models sit at elevated Y positions. Created DEAD_END geometry preset with proper bounds and added BoundsUtil (inspired by CSM RotationUtils) for clean facing-based rotation of bounds and offsets. Refactored InsulatorGeometry to use dynamic rotation instead of pre-computed NS/EW bound pairs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
EnumFacing.byIndex(0) returns DOWN when the NBT key is missing or corrupt. Since all blocks only use horizontal facings, this caused bounding boxes and connection offsets to use wrong orientations on world rejoin. Added safety fallback to NORTH in all three TE base classes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AngelWingsPanda
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.