Fix blocks displaying as wrong block types (IE model cache collision)#19
Merged
AngelWingsPanda merged 1 commit intomainfrom Apr 13, 2026
Merged
Fix blocks displaying as wrong block types (IE model cache collision)#19AngelWingsPanda merged 1 commit intomainfrom
AngelWingsPanda merged 1 commit intomainfrom
Conversation
IE's ConnModelReal uses a Guava cache keyed by ExtBlockstateAdapter, which compares block state property VALUES but not the Block identity. Blocks with the same facing and connection state (e.g. all blocks with no wires facing north) shared a single cache entry, causing the first block rendered to win and its model to display for all others. Fix: implement ICacheData on all TE base classes and pass the TE via IEProperties.TILEENTITY_PASSTHROUGH in the extended block state. IE reads getCacheData() and includes it in the cache key, ensuring each block type gets its own cached model. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AngelWingsPanda
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE's ConnModelReal uses a Guava cache keyed by ExtBlockstateAdapter, which compares block state property VALUES but not the Block identity. Blocks with the same facing and connection state (e.g. all blocks with no wires facing north) shared a single cache entry, causing the first block rendered to win and its model to display for all others.
Fix: implement ICacheData on all TE base classes and pass the TE via IEProperties.TILEENTITY_PASSTHROUGH in the extended block state. IE reads getCacheData() and includes it in the cache key, ensuring each block type gets its own cached model.