Merged
Conversation
Owner
Author
|
Needed for some of the examples. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cvigilv
reviewed
Oct 23, 2025
src/HyperdimensionalComputing.jl
Outdated
| level, | ||
| level_encoder, | ||
| level_decoder, | ||
| levels_encoder_decoder |
Collaborator
There was a problem hiding this comment.
I would try to remain as close as Base Julia as possible in the naming convention of this functions:
level_encoder->encodelevellevel_decoder->decodelevellevels_encoder_decoder->convertlevel(implies dibirectionality)
Collaborator
There was a problem hiding this comment.
or levelconverters.
either way, I think this is unnecessary in most cases.
Collaborator
There was a problem hiding this comment.
Also, this are all random level hypervectors. Any intention on adding the other types of level encodings (i.e. thermometer, circular and island)?
Owner
Author
There was a problem hiding this comment.
Yes, we should do this as well, but I need to look into it in detail. This can be done using level with keyword args.
I'll rename the functions.
cvigilv
reviewed
Oct 23, 2025
cvigilv
approved these changes
Oct 23, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cvigilv
approved these changes
Oct 23, 2025
Owner
Author
|
This addresses #35 and I think may be merged if checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This have some additional functionality for encoding numerical values :
similaritycan now generate a similarity matrix