Open
Conversation
|
Hey Thiemen, very detailed notebook on GNA and LMA! I very much enjoyed the metaphorical image 🍧 and liked how you progressively explained the formulas. One simple suggestion: It would really add to the notebook if you not leave the reader with her pure imagination but also add a few images to your notebook to better illustrate the matter. You don't even have to create plots yourself, e.g. for the famous Rosenbrock function there are tons of CC-BY-SA licensed images out there. If you are concerned about formatting issues, please check the intermezzo on Taylor approximations: "Replacing x in the polynomial is possible because [...]" is wrongly formatted. Keep it up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Thiemen!
I just ran and read your notebook, and I really thought the notebook was impressive: the structure was nice and the content was very informative.
Just as a person who overused PlutoUI in his project, the only comment I can give is the visualization in the implementation section.
Maybe a bar chart to better visualize the differing iterations between algorithms? or maybe a line graph of how LMA requires more iterations with increasing lambda values?
It already looks great. Take my feedback with a grain of salt.