Link between fractals and the Newton method (Review)#41
Open
NatanTourne wants to merge 18 commits intoMichielStock:masterfrom
Open
Link between fractals and the Newton method (Review)#41NatanTourne wants to merge 18 commits intoMichielStock:masterfrom
NatanTourne wants to merge 18 commits intoMichielStock:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
The issue tab is not enabled, so I'm putting my review here.
The notebook looks very nice, the concepts are well explained and the figures are informative illustrations of what is happening.
My only remark is that the code could be better annotated (although most of it is pretty intuitive), and especially the functions could use a description.
Kind regards,
Natan