You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice project, I would maybe shorten the general explanation of the algorithm in the documentation, with the notebook available this might be a little bit of an overkill. The input and output explanations are not always necessary, but I understand that you want to be consistent. If I run the tests I get an error, they don't fail but there is an error, because the objective_value and the initial_population functions can't be found. I tried to export them by your module but that didn't solve it. For the rest the code looks great.
@KobeDeTemmerman thank you for the nice feedback, indeed there were some errors in the package that occurred because of last changes. We fixed the errors and everything works now. I assume you couldn't open the notebook as well but now this should be possible without any further efforts (feel free to check it out, it's very nice). Again our sincere apologies for the code issues and hope u enjoyed it. grtz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request from correct branch