Skip to content

Comments

Bees algorithm#6

Open
kirstvh wants to merge 88 commits intoMichielStock:masterfrom
kirstvh:BeesAlgorithm
Open

Bees algorithm#6
kirstvh wants to merge 88 commits intoMichielStock:masterfrom
kirstvh:BeesAlgorithm

Conversation

@kirstvh
Copy link
Contributor

@kirstvh kirstvh commented Nov 25, 2020

Pull request from correct branch

@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #6 (e4060eb) into master (bc81b6e) will decrease coverage by 9.72%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #6      +/-   ##
===========================================
- Coverage   100.00%   90.27%   -9.73%     
===========================================
  Files            2        3       +1     
  Lines            4      144     +140     
===========================================
+ Hits             4      130     +126     
- Misses           0       14      +14     
Impacted Files Coverage Δ
src/STMOZOO.jl 100.00% <ø> (ø)
src/example.jl 100.00% <ø> (ø)
src/beesalgorithm.jl 90.00% <90.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc81b6e...e4060eb. Read the comment docs.

@MichielStock
Copy link
Owner

Needs to be reviewed by @KobeDeTemmerman and @Cengoni.

@KobeDeTemmerman
Copy link
Contributor

Nice project, I would maybe shorten the general explanation of the algorithm in the documentation, with the notebook available this might be a little bit of an overkill. The input and output explanations are not always necessary, but I understand that you want to be consistent. If I run the tests I get an error, they don't fail but there is an error, because the objective_value and the initial_population functions can't be found. I tried to export them by your module but that didn't solve it. For the rest the code looks great.

@tjvneste
Copy link

tjvneste commented Jan 8, 2021

@KobeDeTemmerman thank you for the nice feedback, indeed there were some errors in the package that occurred because of last changes. We fixed the errors and everything works now. I assume you couldn't open the notebook as well but now this should be possible without any further efforts (feel free to check it out, it's very nice). Again our sincere apologies for the code issues and hope u enjoyed it. grtz

@MichielStock MichielStock changed the title Bees algorithm test 25/11 Bees algorithm Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants