Used includes for shared content in ARM articles #3890
+94
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ManikaDhiman : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 4ee684a: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
PRMerger Results
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Azure Local ARM template documentation by extracting duplicated content into reusable include files. The changes improve maintainability by consolidating shared procedures for creating service principals and getting object IDs that were previously duplicated across multiple articles.
- Moved service principal creation steps to a shared include file
- Moved Azure Local Resource Provider object ID retrieval steps to a shared include file
- Updated documentation dates and restructured content organization
Reviewed Changes
Copilot reviewed 4 out of 20 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| install-solution-upgrade-azure-resource-manager-template.md | Replaced duplicated content with include statements and reorganized sections |
| get-object-id-azure-local-resource-provider.md | New include file containing steps to retrieve Azure Local Resource Provider object ID |
| create-service-principal-client-secret.md | New include file containing service principal and client secret creation procedures |
| deployment-azure-resource-manager-template.md | Replaced duplicated content with include statements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| ### Get the object ID for Azure Local Resource Provider | ||
|
|
||
| This object ID for the Azure Local Resource Provide (RP) is unique per Azure tenant. |
There was a problem hiding this comment.
There's a typo in 'Provide' which should be 'Provider'.
Suggested change
| This object ID for the Azure Local Resource Provide (RP) is unique per Azure tenant. | |
| This object ID for the Azure Local Resource Provider (RP) is unique per Azure tenant. |
Copilot uses AI. Check for mistakes.
| 1. Copy the **client secret value** as you use it later. | ||
|
|
||
| > [!Note] | ||
| > For the application client ID, you will need it's secret value. Client secret values can't be viewed except for immediately after creation. Be sure to save this value when created before leaving the page. |
There was a problem hiding this comment.
The contraction 'it's' should be 'its' (possessive form) in this context.
Suggested change
| > For the application client ID, you will need it's secret value. Client secret values can't be viewed except for immediately after creation. Be sure to save this value when created before leaving the page. | |
| > For the application client ID, you will need its secret value. Client secret values can't be viewed except for immediately after creation. Be sure to save this value when created before leaving the page. |
Copilot uses AI. Check for mistakes.
|
Can you review the proposed changes? If you approve the new content in this PR, the commits must be moved to the private repository for automated checks and publishing. After you move the commits, close this PR ( Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
prmerger-automator
bot
added
the
aq-pr-triaged
|
Learn Build status updates of commit 17c2486: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
PRMerger Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.