This repository was archived by the owner on Dec 2, 2021. It is now read-only.
Feature/use endaq #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrepeGoat
force-pushed
the
feature/use-endaq
branch
from
870cdf1 to
24404a6
Compare
SamRagusa
reviewed
Nov 1, 2021
Comment on lines
-171
to
+143
| return np.empty((3, 0), dtype=np.float) | ||
| return pd.DataFrame( | ||
| np.empty((0, 3), dtype=np.float), | ||
| index=pd.Series([], name="time"), | ||
| columns=pd.Series(["X", "Y", "Z"], name="axis"), | ||
| ) |
There was a problem hiding this comment.
I'm not sure what specifically is using this output, but it can be risky returning data initialized by np.empty.
There was a problem hiding this comment.
Generally I'd agree, but in this case the generated array is of shape (0, 3), meaning it has no elements. So here there's not really any risk of e.g. non-determinism or pseudo-memory-leaking or anything like that.
CrepeGoat
force-pushed
the
feature/use-endaq
branch
from
082015d to
f62ad70
Compare
CrepeGoat
force-pushed
the
feature/use-endaq
branch
from
f62ad70 to
b31fa91
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one, but I don't expect a thorough review of all the changes. The big ones are:
nre_utilscode and replaced it with the correspondingendaq.calcfunctionsendaq.ide.get_docendaq.ide/calcdirectly from GitHub -> this lets me use any fixes in those codebases (e.g., Fix/butterworth endaq-python-calc#55)