added ability to return the reply just like that#5
Open
adambrangenberg wants to merge 18 commits intoMihirBhave:mainfrom
Open
added ability to return the reply just like that#5adambrangenberg wants to merge 18 commits intoMihirBhave:mainfrom
adambrangenberg wants to merge 18 commits intoMihirBhave:mainfrom
Conversation
- using official way to add guild commands - added callbacks, so the message comes after the command being registered
Some style improvements
path.join() --> join() using not brackets for oneliners fixed grammar <3
Async adds more ticks to the event loop, and await wasn't used. By removing it, the code is getting faster.
Code review with suggested improvements
… understand easier
Removed some if/else spaghetti code, read commits for more info
Contributor
|
dis is truly epik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
return { content: "hi", ephemeral: true" }
or:
return "hi"