Reworked to work with the steam new email format#1
Open
itsjfx wants to merge 10 commits intoMijago:masterfrom
Open
Reworked to work with the steam new email format#1itsjfx wants to merge 10 commits intoMijago:masterfrom
itsjfx wants to merge 10 commits intoMijago:masterfrom
Conversation
Callback now returns the URL from the steam email, this is done through string manipulation (splits and pops). Not sure if there's a more efficient URL parsing library in node.js but this seemed to work well. The URL can be requested using request to verify the email, however I decided that returning the URL would be adequate as the user can choose how they can verify the request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callback now returns the URL from the steam email, this is done through string manipulation (splits and pops).
Not sure if there's a more efficient URL parsing library in node.js but this seemed to work well.
The URL can be requested using request to verify the email, however I decided that returning the URL would be adequate as the user can choose how they can verify the request.