-
Notifications
You must be signed in to change notification settings - Fork 2
Finding Allowlist & Suppression #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MikeeBuilds
wants to merge
13
commits into
main
Choose a base branch
from
auto-claude/007-finding-allowlist-suppression
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fc9ba5c
auto-claude: subtask-1-1 - Create suppression.sh helper with load_sup…
MikeeBuilds 4c80059
auto-claude: subtask-2-1 - Add --show-suppressed and --no-ignore flag…
MikeeBuilds d53c404
auto-claude: subtask-2-2 - Source suppression.sh and apply filtering …
MikeeBuilds 9e90970
auto-claude: subtask-3-2 - Update interactive/terminal output to show…
MikeeBuilds 7041a3f
auto-claude: subtask-3-3 - Add --show-suppressed display logic to inc…
MikeeBuilds 28e121f
auto-claude: subtask-4-1 - Create .clawpinch-ignore.json.example with…
MikeeBuilds 832f3ee
auto-claude: subtask-4-2 - Update README.md with suppression document…
MikeeBuilds 8f59a63
auto-claude: subtask-4-3 - Update CLAUDE.md and SKILL.md with suppres…
MikeeBuilds ee007ef
auto-claude: subtask-6-1 - Test suppression with no expiry
MikeeBuilds 22b5b8f
auto-claude: subtask-6-2 - Test suppression with expiration (future a…
MikeeBuilds ead3cd2
fix: address review feedback — fix dirname bug, optimize jq filtering…
MikeeBuilds bbe77b0
fix: address round 3 review — harden suppression, consolidate jq, rem…
MikeeBuilds 3b7a7d3
fix: address PR #17 review — revert to individual jq calls, remove de…
MikeeBuilds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| { | ||
| "$schema": "https://clawpinch.dev/schemas/ignore.json", | ||
| "_comment": "This file configures finding suppression for ClawPinch security scans", | ||
| "_documentation": { | ||
| "purpose": "Suppress accepted-risk findings to prevent CI/CD pipeline failures", | ||
| "location": "Copy this file to .clawpinch-ignore.json in your project root", | ||
| "fields": { | ||
| "id": "(required) Check ID to suppress (e.g., CHK-CFG-001)", | ||
| "reason": "(required) Justification for suppressing this finding", | ||
| "expires": "(optional) ISO 8601 timestamp when suppression expires and finding reactivates", | ||
| "suppressed_by": "(optional) Email or identifier of person who approved suppression", | ||
| "suppressed_at": "(optional) ISO 8601 timestamp when suppression was created" | ||
| }, | ||
| "behavior": { | ||
| "suppressed_findings": "Moved to 'suppressed' array in JSON output, excluded from severity counts", | ||
| "expired_suppressions": "Automatically reactivated if expires date is in the past", | ||
| "flags": { | ||
| "--show-suppressed": "Include suppressed findings in output with [SUPPRESSED] marker", | ||
| "--no-ignore": "Disable all suppressions for full audit scans" | ||
| } | ||
| } | ||
| }, | ||
| "suppressions": [ | ||
| { | ||
| "id": "CHK-CFG-001", | ||
| "reason": "Dev environment - open gateway is intentional for local testing", | ||
| "expires": "2025-12-31T23:59:59Z", | ||
| "suppressed_by": "devops@example.com", | ||
| "suppressed_at": "2024-01-15T10:30:00Z" | ||
| }, | ||
| { | ||
| "id": "CHK-SEC-003", | ||
| "reason": "Test API key in example config - not used in production deployments" | ||
| }, | ||
| { | ||
| "id": "CHK-NET-004", | ||
| "reason": "WebSocket endpoint exposed for real-time collaboration feature", | ||
| "expires": "2025-06-30T00:00:00Z", | ||
| "suppressed_by": "security-team@example.com" | ||
| }, | ||
| { | ||
| "id": "CHK-PRM-002", | ||
| "reason": "Wildcard permission required for dynamic skill loader - reviewed by security", | ||
| "suppressed_by": "ciso@example.com", | ||
| "suppressed_at": "2024-02-20T14:30:00Z" | ||
| }, | ||
| { | ||
| "id": "CHK-CRN-001", | ||
| "reason": "Cron job needs elevated permissions for system maintenance tasks", | ||
| "expires": "2025-03-01T00:00:00Z" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation shows
suppressionobject in JSON output, butfilter_findings()atscripts/helpers/suppression.sh:173-185doesn't add it - just copies findings as-is.Either enrich findings with metadata or update docs to reflect actual output format.
Prompt To Fix With AI