-
Notifications
You must be signed in to change notification settings - Fork 2
Add integrity verification for reference JSON files #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MikeeBuilds
wants to merge
11
commits into
main
Choose a base branch
from
auto-claude/005-add-integrity-verification-for-reference-json-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9612d66
auto-claude: subtask-1-1 - Generate SHA256 checksum files for referen…
MikeeBuilds 741f27f
auto-claude: subtask-1-2 - Create verify_json_integrity() function in…
MikeeBuilds 9089d50
auto-claude: subtask-1-3 - Create script to regenerate checksums when…
MikeeBuilds 199de43
auto-claude: subtask-2-1 - Update scan_cves.sh to verify known-cves.j…
MikeeBuilds 9f500da
auto-claude: subtask-2-2 - Update scan_skills.sh to verify malicious-…
MikeeBuilds 0a9098b
auto-claude: subtask-2-3 - Update scan_supply_chain.sh to verify mali…
MikeeBuilds 50ac901
auto-claude: subtask-3-1 - Test integrity verification with valid che…
MikeeBuilds 24623ec
auto-claude: subtask-3-3 - Update documentation with integrity verifi…
MikeeBuilds 4a6d8d0
fix: address review feedback — fix command injection in python3 -c, u…
MikeeBuilds 68155df
fix: address round 3 review — dynamic file discovery, safer hash capture
MikeeBuilds 1f5105f
fix: sanitize filenames in evidence fields and remove redundant check
MikeeBuilds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| 5b76edfb8d14fe79c3a60d2d7703685df76bd072a01f0a882310e457b587d371 known-cves.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| cced9255346755091ddf1d592cddb3185945ad3f2a7f33de3d131b00286ae9d8 malicious-patterns.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checksum file not validated
verify_json_integrity()only reads the first whitespace-delimited field from the.sha256file and ignores the filename field entirely. If the.sha256file is malformed or points at a different filename than the JSON being verified, this still passes as long as the first token matches the JSON’s hash. That defeats the “standard format” guarantee documented elsewhere and makes integrity checks easier to accidentally misconfigure (or intentionally confuse) without detection.Prompt To Fix With AI